[SYCL][DOC] Refactor OCL global variable spec #5659
Conversation
We decided that the OpenCL API Specification should not contain detailed information about how the APIs interact with SPIR-V. Instead, we want this information in the OpenCL SPIR-V Environment Specification. Change this extension specification accordingly.
There was a problem hiding this comment.
Thanks, this looks good to me. 👍
At some point we may decide that the modifications to the SPIR-V environment spec belong more with whatever extension or tooling describes support SPV_INTEL_global_variable_decorations rather than here, but we can work that out later if necessary. The important thing for now is that the name resolution will be documented in the SPIR-V environment spec.
| parameter which identifies the variable. This parameter is interpreted as | ||
| follows: |
There was a problem hiding this comment.
I'd consider saying explicitly that this section only applies for programs created via SPIR-V, perhaps by adding to the last sentence:
For a
cl_programcreated from SPIR-V, this parameter is interpreted as follows...
Debatably this is unnecessary because this section is in the SPIR-V environment specification, but I still think it is clearer to say it explicitly.
There was a problem hiding this comment.
Makes sense. Done in 39cad4d
Comment from Ben, clarify that these rules apply only if the module was created from SPIR-V.
Yes, I agree. It might be better to create a GitHub "team" for the OpenCL spec reviewers, similar to the way we have "intel/dpcpp-spirv-reviewers" for SPIR-V specs. We could then add @bashbaug to that team and potentially others. |
We decided that the OpenCL API Specification should not contain
detailed information about how the APIs interact with SPIR-V. Instead,
we want this information in the OpenCL SPIR-V Environment
Specification.
Change this extension specification accordingly.